Hello @gzotti!

Thank you for the suggested improvement.

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

• Are possibly unused includes removed?

Files matching guide/**:

• Did you remember to update screenshots to match new updates?
• Did you remember to grammar check in changed part of documentation?

Files matching skycultures/**:

• Did you remember to update skycultures/CMakeLists.txt file respectively to changes in sky cultures?
• Did you remember to define classification parameter in sky cultures (see index.json file)?
• Did you remember to define license parameter in sky cultures (see description.md file)?
• Did you remember to define region parameter in sky culture (see index.json file)?

This is an automatically generated QA checklist based on modified files.

Where is the code for extraction byname tag into pot file?

Good question. Where do I find the code for extraction of the other translatable strings for skycultures? (E.g. pronounce tag)

Please check util/skycultures

I hope this works, I never tested these tools.

Aren't bynames supposed to be translated? Your change to generate-pot.py will only update the comments for translators, but not the byname itself.

You can simply run the script yourself to see how it will change the .pot. You don't have to commit the .pot itself for now, resetting its change after checking the results, but you should try the script anyways. Any dependencies are installable via pip.

bynames should be translated, and 'pronounce' as well. But is that implemented somewhere?

and 'pronounce' as well

Oh really? No, at least judging by the .pot file, these aren't extracted. So in addition to if english: there should be cases for all the translatable others.

This seems to work. Not sure about correct uniqueness (context?), though.

This is good for me, but please check the CodeFactor warnings

I fixed the whitespace warning. However, the extraction of pronounce in light of Chinese "added" name parts is beyond my current reading level. I marked where I see missing functionality. Anybody else?

OK for me

Running the script gives some entries like this:

#. Chinese constellation, native: 八谷, pronounce: Ba Gu
#. Chinese Chenzhuo Sky (3rd Century) constellation, native: 八谷, pronounce: Ba
#. Gu
#. Chinese Song Dynasty Sky constellation, native: 八谷, pronounce: Ba Gu
msgid "Ba Gu"
msgstr ""

Since it's an entry for the "pronounce" field, the comment should also say the English version if available, just like the "english" fiels have the transcribed versions.

Not quite related, but I also get some entries like this:

#. Babylonian (Seleucid) constellation, native:  , pronounce: Alu
msgid "Alu"
msgstr ""

This has already existed before this PR, but why do we have non-empty native names that consist just of a single space?

And this is even uglier:

#. Chinese Song Dynasty Sky constellation, native:  , pronounce:  
msgid " "
msgstr ""

This is an entry with three names, all of which are garbage: "common_name": {"english": "", "native": " ", "pronounce": " "}.

A right, the english could go into the comment of the pronounce.
I don't know what to do about missing data when authors provide empty or whitespace strings.

Hello @gzotti!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

Hello @gzotti!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest